lkml.org 
[lkml]   [2022]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH v2 05/12] signal: Use lockdep_assert_held instead of assert_spin_locked
    The distinction is that assert_spin_locked() checks if the lock is
    held *by*anyone* whereas lockdep_assert_held() asserts the current
    context holds the lock. Also, the check goes away if you build
    without lockdep.

    Suggested-by: Peter Zijlstra <peterz@infradead.org>
    Link: https://lkml.kernel.org/r/Ympr/+PX4XgT/UKU@hirez.programming.kicks-ass.net
    Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
    ---
    kernel/signal.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/kernel/signal.c b/kernel/signal.c
    index 72d96614effc..3fd2ce133387 100644
    --- a/kernel/signal.c
    +++ b/kernel/signal.c
    @@ -884,7 +884,7 @@ static int check_kill_permission(int sig, struct kernel_siginfo *info,
    static void ptrace_trap_notify(struct task_struct *t)
    {
    WARN_ON_ONCE(!(t->ptrace & PT_SEIZED));
    - assert_spin_locked(&t->sighand->siglock);
    + lockdep_assert_held(&t->sighand->siglock);

    task_set_jobctl_pending(t, JOBCTL_TRAP_NOTIFY);
    ptrace_signal_wake_up(t, t->jobctl & JOBCTL_LISTENING);
    @@ -1079,7 +1079,7 @@ static int __send_signal_locked(int sig, struct kernel_siginfo *info,
    int override_rlimit;
    int ret = 0, result;

    - assert_spin_locked(&t->sighand->siglock);
    + lockdep_assert_held(&t->sighand->siglock);

    result = TRACE_SIGNAL_IGNORED;
    if (!prepare_signal(sig, t, force))
    --
    2.35.3
    \
     
     \ /
      Last update: 2022-04-29 23:51    [W:4.042 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site