Messages in this thread |  | | Date | Thu, 28 Apr 2022 13:18:00 +0200 | | From | Jan Kara <> | | Subject | Re: [PATCH -next v4 1/3] block, bfq: record how many queues are busy in bfq_group |
| |
On Thu 28-04-22 19:19:05, Yu Kuai wrote: > Prepare to refactor the counting of 'num_groups_with_pending_reqs'. > > Add a counter 'busy_queues' in bfq_group, and update it in > bfq_add/del_bfqq_busy(). > > Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Just two nits below:
> --- a/block/bfq-wf2q.c > +++ b/block/bfq-wf2q.c > @@ -218,6 +218,16 @@ static bool bfq_no_longer_next_in_service(struct bfq_entity *entity) > return false; > } > > +static void bfq_add_busy_queues(struct bfq_queue *bfqq) > +{ > + bfqq_group(bfqq)->busy_queues++; > +} > + > +static void bfq_dec_busy_queues(struct bfq_queue *bfqq) > +{ > + bfqq_group(bfqq)->busy_queues--; > +} > +
An opposite from "decrement" is "increment", not "add". So bfq_add_busy_queues() should be bfq_inc_busy_queues().
> @@ -230,6 +240,14 @@ static bool bfq_no_longer_next_in_service(struct bfq_entity *entity) > return true; > } > > +static void bfq_add_busy_queues(struct bfq_queue *bfqq) > +{ > +} > + > +static void bfq_add_busy_queues(struct bfq_queue *bfqq) > +{ > +} > +
You have two times the same function here and you miss the other one...
Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR
|  |