lkml.org 
[lkml]   [2022]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [memcg] a8c49af3be: hackbench.throughput -13.7% regression
From

On 4/27/2022 1:02 PM, Shakeel Butt wrote:
> Hi Yin,
>
> On Tue, Apr 26, 2022 at 7:53 PM Yin Fengwei <fengwei.yin@intel.com> wrote:
>>
> [...]
>>
>> If I comment out one line added by the commit <a8c49af3be> :
>> static void memcg_account_kmem(struct mem_cgroup *memcg, int nr_pages)
>> {
>> /* mod_memcg_state(memcg, MEMCG_KMEM, nr_pages); */ <--- comment out this line.
>
> Can you to comment out the following block instead of the above line
> and see if there is any impact?
>
>> if (!cgroup_subsys_on_dfl(memory_cgrp_subsys)) {
>> if (nr_pages > 0)
>> page_counter_charge(&memcg->kmem, nr_pages);
>> else
>> page_counter_uncharge(&memcg->kmem, -nr_pages);
>> }
>> }
OK. I will give it a try and send the result out.


Regards
Yin, Fengwei

>>

\
 
 \ /
  Last update: 2022-04-27 07:04    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog