Messages in this thread | | | From | "Hawkins, Nick" <> | Subject | RE: [PATCH v5 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding | Date | Tue, 26 Apr 2022 13:21:37 +0000 |
| |
-----Original Message----- From: Rob Herring [mailto:robh@kernel.org] Sent: Monday, April 25, 2022 5:05 PM To: Hawkins, Nick <nick.hawkins@hpe.com> Cc: Verdun, Jean-Marie <verdun@hpe.com>; joel@jms.id.au; arnd@arndb.de; openbmc@lists.ozlabs.org; Wim Van Sebroeck <wim@linux-watchdog.org>; Guenter Roeck <linux@roeck-us.net>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; linux-watchdog@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding
(...)
> How is this h/w controlled? I'm guessing it's part of the timer? If so, you don't need this node. A single node can implement multiple functions.
It is associated with the timer because of the shared register set. Based on feedback from Krzysztof I need to create a child node for gxp-timer. I therefore will remove this file and move gxp-wdt to the hpe,gxp-timer.yaml as a child node.
Thank you for the feedback.
-Nick Hawkins
| |