Messages in this thread | | | Date | Sat, 23 Apr 2022 13:17:52 +0800 | From | kernel test robot <> | Subject | Re: [PATCH v2 11/11] smp: modify up.c to adopt the same format of cross CPU call. |
| |
Hi Donghai,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on powerpc/next] [also build test ERROR on rafael-pm/linux-next linus/master v5.18-rc3] [cannot apply to tip/x86/core next-20220422] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Donghai-Qiao/smp-cross-CPU-call-interface/20220423-060436 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: x86_64-randconfig-a013 (https://download.01.org/0day-ci/archive/20220423/202204231333.D1x82f1d-lkp@intel.com/config) compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/655b898028ef1555f6bec036db8d4681b551aaa8 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Donghai-Qiao/smp-cross-CPU-call-interface/20220423-060436 git checkout 655b898028ef1555f6bec036db8d4681b551aaa8 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
kernel/up.c: In function 'smp_call_mask': >> kernel/up.c:50:18: error: 'cpu' undeclared (first use in this function); did you mean 'fpu'? 50 | smp_call(cpu, func, info, type); | ^~~ | fpu kernel/up.c:50:18: note: each undeclared identifier is reported only once for each function it appears in kernel/up.c:44:23: warning: unused variable 'flags' [-Wunused-variable] 44 | unsigned long flags; | ^~~~~ kernel/up.c: In function 'smp_call_mask_cond': kernel/up.c:80:26: error: 'cpu' undeclared (first use in this function); did you mean 'fpu'? 80 | smp_call(cpu, func, info, type); | ^~~ | fpu kernel/up.c:76:23: warning: unused variable 'flags' [-Wunused-variable] 76 | unsigned long flags; | ^~~~~ In file included from include/linux/percpu.h:7, from include/linux/context_tracking_state.h:5, from include/linux/hardirq.h:5, from include/linux/interrupt.h:11, from kernel/up.c:6: At top level: include/linux/smp.h:131:14: warning: 'seq_type' defined but not used [-Wunused-variable] 131 | static char *seq_type[] = { | ^~~~~~~~
vim +50 kernel/up.c
41 42 void smp_call_mask(const struct cpumask *mask, smp_call_func_t func, void *info, unsigned int type) 43 { 44 unsigned long flags; 45 46 if (!cpumask_test_cpu(0, mask)) 47 return; 48 49 preempt_disable(); > 50 smp_call(cpu, func, info, type); 51 preempt_enable(); 52 } 53 EXPORT_SYMBOL(smp_call_mask); 54
-- 0-DAY CI Kernel Test Service https://01.org/lkp
| |