Messages in this thread | | | Subject | Re: [PATCH V2 05/12] clk: mediatek: reset: Add reset.h | From | Rex-BC Chen <> | Date | Fri, 22 Apr 2022 13:02:45 +0800 |
| |
On Thu, 2022-04-21 at 11:07 +0200, AngeloGioacchino Del Regno wrote: > Il 20/04/22 15:05, Rex-BC Chen ha scritto: > > Add a new file "reset.h" to place some definitions for clock reset. > > > > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com> > > Right now, you're adding the enum mtk_reset_version and *then* you're > moving it to the new reset.h header, but does that really make sense? > > I think that this series would be cleaner if you add this header from > the start, so that you place the aforementioned enumeration directly > in here... > > ...so we would have a commit that moves the > mtk_clk_register_rst_ctrl() > function from clk-mtk.h to a newly created reset.h, mentioning in the > commit description that it's all about preparing for a coming > cleanup, > then the addition of enum mtk_reset_version would be in > `clk: mediatek: reset: Merge and revise reset register function` > directly > into reset.h. > > Does that sound right to you? > > Cheers, > Angelo >
Hello Angelo,
yes, I think it's more reasonable to move this modification to the first order of this series. I will do this in next version.
BRs, Rex
| |