Messages in this thread | | | Subject | Re: [PATCH v2] clk: imx: scu: Use pm_runtime_resume_and_get to fix pm_runtime_get_sync() usage | From | Stephen Boyd <> | Date | Fri, 22 Apr 2022 19:23:30 -0700 |
| |
Quoting Miaoqian Lin (2022-04-21 18:59:54) > > On 2022/4/22 9:44, Stephen Boyd wrote: > > Quoting Miaoqian Lin (2022-04-21 18:33:16) > >> If the device is already in a runtime PM enabled state > >> pm_runtime_get_sync() will return 1. > >> > >> Also, we need to call pm_runtime_put_noidle() when pm_runtime_get_sync() > >> fails, so use pm_runtime_resume_and_get() instead. this function > >> will handle this. > >> > >> Fixes: 78edeb080330 ("clk: imx: scu: add runtime pm support") > >> Signed-off-by: Miaoqian Lin <linmq006@gmail.com> > >> --- > > Please don't send patches as replies to previous versions of the patch. > > Sorry, I thought I should keep them in one thread, to provide the context
Please link back to previous revisions with lore.
https://lore.kernel.org/r/<message-id-of-rev1>
and then add a change log below the triple dash referencing that lore link and anything that has changed since that revision.
> > for other people to follow up. Am I suppose to resend it?
Yes. Might as well practice making a changelog at the same time.
| |