Messages in this thread | | | Date | Thu, 21 Apr 2022 21:15:48 +0800 | Subject | Re: [External] Re: [PATCH] sched/core: Avoid obvious double update_rq_clock warning | From | Hao Jia <> |
| |
On 2022/4/21 Dietmar Eggemann wrote: > On 18/04/2022 11:09, Hao Jia wrote: > > [...] > >> - /* >> - * Update the later_rq clock here, because the clock is used >> - * by the cpufreq_update_util() inside __add_running_bw(). >> - */ >> - update_rq_clock(later_rq); >> - activate_task(later_rq, next_task, ENQUEUE_NOCLOCK); >> + activate_task(later_rq, next_task, 0); > > IMHO, this change should go in a separate deadline patch. >
Thanks again for your review. I will do it in patch v2. Thanks.
> The change to call update_rq_clock() before activate_task() > (840d719604b09) is no longer needed since f4904815f97a removed the > add_running_bw() before the activate_task(). > > [...]
| |