lkml.org 
[lkml]   [2022]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] drm/msm: change msm_sched_ops from global to static
    Date
    Smatch reports this issue
    msm_ringbuffer.c:43:36: warning: symbol 'msm_sched_ops' was not declared. Should it be static?

    msm_sched_ops is only used in msm_ringbuffer.c so change its
    storage-class specifier to static.

    Signed-off-by: Tom Rix <trix@redhat.com>
    ---
    drivers/gpu/drm/msm/msm_ringbuffer.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/msm/msm_ringbuffer.c b/drivers/gpu/drm/msm/msm_ringbuffer.c
    index 367a6aaa3a20..66f4ec09ef67 100644
    --- a/drivers/gpu/drm/msm/msm_ringbuffer.c
    +++ b/drivers/gpu/drm/msm/msm_ringbuffer.c
    @@ -40,7 +40,7 @@ static void msm_job_free(struct drm_sched_job *job)
    msm_gem_submit_put(submit);
    }

    -const struct drm_sched_backend_ops msm_sched_ops = {
    +static const struct drm_sched_backend_ops msm_sched_ops = {
    .run_job = msm_job_run,
    .free_job = msm_job_free
    };
    --
    2.27.0
    \
     
     \ /
      Last update: 2022-04-21 15:15    [W:4.645 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site