lkml.org 
[lkml]   [2022]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] media: amphion: fix error check return value of debugfs_create_file()
From
On 19/04/2022 03:38, cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> If an error occurs, debugfs_create_file() will return ERR_PTR(-ERROR),
> so use IS_ERR() to check it.

Actually, errors should never be checked for debugfs. See e.g. commit
1d8f95c497053839be326bd97eb3128e3b3312cb which removed unnecessary checks
in drivers/media/radio/radio-si476x.c.

Can you make a v2 that removes all the debugfs checks from this driver?

Regards,

Hans

>
> Fixes: 9f599f351e86 ("media: amphion: add vpu core driver")
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> ---
> drivers/media/platform/amphion/vpu_dbg.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/amphion/vpu_dbg.c b/drivers/media/platform/amphion/vpu_dbg.c
> index 376196bea178..5cef1fd41a74 100644
> --- a/drivers/media/platform/amphion/vpu_dbg.c
> +++ b/drivers/media/platform/amphion/vpu_dbg.c
> @@ -413,7 +413,7 @@ int vpu_inst_create_dbgfs_file(struct vpu_inst *inst)
> vpu->debugfs,
> inst,
> &vpu_dbg_inst_fops);
> - if (!inst->debugfs) {
> + if (IS_ERR(inst->debugfs)) {
> dev_err(inst->dev, "vpu create debugfs %s fail\n", name);
> return -EINVAL;
> }
> @@ -451,7 +451,7 @@ int vpu_core_create_dbgfs_file(struct vpu_core *core)
> vpu->debugfs,
> core,
> &vpu_dbg_core_fops);
> - if (!core->debugfs) {
> + if (IS_ERR(core->debugfs)) {
> dev_err(core->dev, "vpu create debugfs %s fail\n", name);
> return -EINVAL;
> }
> @@ -463,7 +463,7 @@ int vpu_core_create_dbgfs_file(struct vpu_core *core)
> vpu->debugfs,
> core,
> &vpu_dbg_fwlog_fops);
> - if (!core->debugfs_fwlog) {
> + if (IS_ERR(core->debugfs_fwlog)) {
> dev_err(core->dev, "vpu create debugfs %s fail\n", name);
> return -EINVAL;
> }

\
 
 \ /
  Last update: 2022-04-21 13:57    [W:0.044 / U:0.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site