lkml.org 
[lkml]   [2022]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[tip: x86/tdx] x86/tdx: Annotate a noreturn function
The following commit has been merged into the x86/tdx branch of tip:

Commit-ID: 5af14c29f7a0e6d1fcee44c4ed4a2d12a49c4a43
Gitweb: https://git.kernel.org/tip/5af14c29f7a0e6d1fcee44c4ed4a2d12a49c4a43
Author: Borislav Petkov <bp@suse.de>
AuthorDate: Wed, 20 Apr 2022 13:45:49 +02:00
Committer: Borislav Petkov <bp@suse.de>
CommitterDate: Thu, 21 Apr 2022 12:54:08 +02:00

x86/tdx: Annotate a noreturn function

objdump complains:

vmlinux.o: warning: objtool: __tdx_hypercall()+0x74: unreachable instruction

because __tdx_hypercall_failed() won't return but panic the guest.
Annotate that that is ok and desired.

Fixes: eb94f1b6a70a ("x86/tdx: Add __tdx_module_call() and __tdx_hypercall() helper functions")
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lore.kernel.org/r/20220420115025.5448-1-bp@alien8.de
---
arch/x86/coco/tdx/tdcall.S | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/x86/coco/tdx/tdcall.S b/arch/x86/coco/tdx/tdcall.S
index 2458882..eeb4511 100644
--- a/arch/x86/coco/tdx/tdcall.S
+++ b/arch/x86/coco/tdx/tdcall.S
@@ -200,5 +200,6 @@ SYM_FUNC_START(__tdx_hypercall)
.Lpanic:
call __tdx_hypercall_failed
/* __tdx_hypercall_failed never returns */
+ REACHABLE
jmp .Lpanic
SYM_FUNC_END(__tdx_hypercall)
\
 
 \ /
  Last update: 2022-04-21 13:04    [W:0.065 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site