lkml.org 
[lkml]   [2022]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH V2 2/2] tty: serial: meson: Added S4 SOC compatibility
    From


    On 2022/4/21 16:49, Neil Armstrong wrote:
    > [ EXTERNAL EMAIL ]
    >
    > On 18/04/2022 07:32, Yu Tu wrote:
    >> Make UART driver compatible with S4 SOC UART. Meanwhile, the S4 SOC
    >> UART uses 12MHz as the clock source for baud rate calculations.
    >>
    >> Signed-off-by: Yu Tu <yu.tu@amlogic.com>
    >> ---
    >>   drivers/tty/serial/meson_uart.c | 8 ++++++++
    >>   1 file changed, 8 insertions(+)
    >>
    >> diff --git a/drivers/tty/serial/meson_uart.c
    >> b/drivers/tty/serial/meson_uart.c
    >> index 58bd2723c004..43941f21735f 100644
    >> --- a/drivers/tty/serial/meson_uart.c
    >> +++ b/drivers/tty/serial/meson_uart.c
    >> @@ -790,11 +790,19 @@ static int meson_uart_remove(struct
    >> platform_device *pdev)
    >>       return 0;
    >>   }
    >> +static struct meson_uart_data s4_uart_date = {
    >
    > Should be s4_uart_data instead of s4_uart_date
    >
    I will prepare the next version and correct it.
    >> +    .has_xtal_div2 = true,
    >> +};
    >> +
    >>   static const struct of_device_id meson_uart_dt_match[] = {
    >>       { .compatible = "amlogic,meson6-uart" },
    >>       { .compatible = "amlogic,meson8-uart" },
    >>       { .compatible = "amlogic,meson8b-uart" },
    >>       { .compatible = "amlogic,meson-gx-uart" },
    >> +    {
    >> +        .compatible = "amlogic,meson-s4-uart",
    >> +        .data = (void *)&s4_uart_date,
    >
    > Here same
    >
    >> +    },
    >>       { /* sentinel */ },
    >>   };
    >>   MODULE_DEVICE_TABLE(of, meson_uart_dt_match);
    > With this change, it's fine for me.
    >
    > Neil
    >
    > .

    \
     
     \ /
      Last update: 2022-04-21 11:48    [W:5.899 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site