Messages in this thread | | | Date | Thu, 21 Apr 2022 11:28:06 +0200 | Subject | Re: [PATCH v13 1/3] dt-binding: mt8183: add Mediatek MDP3 dt-bindings | From | AngeloGioacchino Del Regno <> |
| |
Il 21/04/22 04:46, moudy.ho ha scritto: > On Wed, 2022-04-20 at 11:19 -0500, Rob Herring wrote: >> On Mon, Apr 18, 2022 at 10:22:11AM +0800, Moudy Ho wrote: >>> This patch adds DT binding documents for Media Data Path 3 (MDP3) >>> a unit in multimedia system combined with several components and >>> used for scaling and color format convert. >>> >>> Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> >>> --- >>> .../bindings/media/mediatek,mdp3-rdma.yaml | 166 >>> ++++++++++++++++++ >>> .../bindings/media/mediatek,mdp3-rsz.yaml | 54 ++++++ >>> .../bindings/media/mediatek,mdp3-wrot.yaml | 57 ++++++ >>> .../bindings/soc/mediatek/mediatek,ccorr.yaml | 47 +++++ >>> .../bindings/soc/mediatek/mediatek,wdma.yaml | 58 ++++++ >>> 5 files changed, 382 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml >>> create mode 100644 >>> Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml >>> create mode 100644 >>> Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml >>> create mode 100644 >>> Documentation/devicetree/bindings/soc/mediatek/mediatek,ccorr.yaml >>> create mode 100644 >>> Documentation/devicetree/bindings/soc/mediatek/mediatek,wdma.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3- >>> rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3- >>> rdma.yaml >>> new file mode 100644 >>> index 000000000000..45b7c075ebf5 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3- >>> rdma.yaml >>> @@ -0,0 +1,166 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: >>> https://urldefense.com/v3/__http://devicetree.org/schemas/media/mediatek,mdp3-rdma.yaml*__;Iw!!CTRNKA9wMg0ARbw!3LSlozK4Ddsy4vjMI70PtpvvS39MTVvDGVME_eBDGj7hhW-DSZsoGdwR90ItVI6F$ >>> >>> +$schema: >>> https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!3LSlozK4Ddsy4vjMI70PtpvvS39MTVvDGVME_eBDGj7hhW-DSZsoGdwR96lcJIFE$ >>> >>> + >>> +title: Mediatek Read Direct Memory Access >>> + >>> +maintainers: >>> + - Matthias Brugger <matthias.bgg@gmail.com> >>> + >>> +description: | >>> + Mediatek Read Direct Memory Access(RDMA) component used to do >>> read DMA. >>> + It contains one line buffer to store the sufficient pixel data, >>> and >>> + must be siblings to the central MMSYS_CONFIG node. >>> + For a description of the MMSYS_CONFIG binding, see >>> + Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.ya >>> ml >>> + for details. >>> + The 1st RDMA is also used to be a controller node in Media Data >>> Path 3(MDP3) >>> + that containing MMSYS, MUTEX, GCE and SCP settings. >>> + >>> +properties: >>> + compatible: >>> + items: >>> + # MDP3 controller node >>> + - const: mediatek,mt8183-mdp3 >>> + - const: mediatek,mt8183-mdp3-rdma >> >> This *still* makes no sense. I'm not looking at this further. >> >> Rob > > Hi Rob, > > Apologize for the misunderstanding with your comments in version 12, I > will recheck and delete the SW related information. > > Thanks, > Moudy >
Hello Moudy, As an afterthought, I think that a commit title like
dt-bindings: mediatek: Add bindings for MediaTek MDP3 components
would be explaining what you're doing in a more concise manner.
Regards, Angelo
| |