lkml.org 
[lkml]   [2022]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V2 07/12] clk: mediatek: reset: Add return for clock reset register function
From
Il 20/04/22 15:05, Rex-BC Chen ha scritto:
> To make error handling, we add return for mtk_clk_register_rst_ctrl().
>
> Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> ---
> drivers/clk/mediatek/reset.c | 14 ++++++++------
> drivers/clk/mediatek/reset.h | 4 ++--
> 2 files changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/clk/mediatek/reset.c b/drivers/clk/mediatek/reset.c
> index d67c13958458..b164b1da7dd3 100644
> --- a/drivers/clk/mediatek/reset.c
> +++ b/drivers/clk/mediatek/reset.c

..snip..

> @@ -103,6 +103,8 @@ void mtk_clk_register_rst_ctrl(struct device_node *np,
> pr_err("could not register reset controller: %d\n", ret);
> kfree(data);

If you return for all error conditions, you can return 0 at the end, so here:

return ret;

> }
> +
> + return ret;

and here:

return 0;

> }
>
> MODULE_LICENSE("GPL");


Cheers,
Angelo

\
 
 \ /
  Last update: 2022-04-21 11:08    [W:1.217 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site