Messages in this thread | | | Date | Thu, 21 Apr 2022 11:07:54 +0200 | Subject | Re: [PATCH V2 05/12] clk: mediatek: reset: Add reset.h | From | AngeloGioacchino Del Regno <> |
| |
Il 20/04/22 15:05, Rex-BC Chen ha scritto: > Add a new file "reset.h" to place some definitions for clock reset. > > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Right now, you're adding the enum mtk_reset_version and *then* you're moving it to the new reset.h header, but does that really make sense?
I think that this series would be cleaner if you add this header from the start, so that you place the aforementioned enumeration directly in here...
...so we would have a commit that moves the mtk_clk_register_rst_ctrl() function from clk-mtk.h to a newly created reset.h, mentioning in the commit description that it's all about preparing for a coming cleanup, then the addition of enum mtk_reset_version would be in `clk: mediatek: reset: Merge and revise reset register function` directly into reset.h.
Does that sound right to you?
Cheers, Angelo
| |