lkml.org 
[lkml]   [2022]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V4] staging: rtl8192e: Fix signedness bug in rtllib_rx_assoc_resp()
Hi Haowen,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v5.18-rc3]
[also build test ERROR on next-20220421]
[cannot apply to staging/staging-testing]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Haowen-Bai/staging-rtl8192e-Fix-signedness-bug-in-rtllib_rx_assoc_resp/20220421-093531
base: b2d229d4ddb17db541098b83524d901257e93845
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220421/202204211558.TapLZO4j-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/e1395cdafd4dea7a368f2d9599832636035a03d2
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Haowen-Bai/staging-rtl8192e-Fix-signedness-bug-in-rtllib_rx_assoc_resp/20220421-093531
git checkout e1395cdafd4dea7a368f2d9599832636035a03d2
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash drivers/staging/rtl8192e/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

drivers/staging/rtl8192e/rtllib_softmac.c: In function 'auth_parse':
>> drivers/staging/rtl8192e/rtllib_softmac.c:1792:29: error: 'ieee' undeclared (first use in this function)
1792 | netdev_info(ieee->dev, "auth_parse() failed");
| ^~~~
drivers/staging/rtl8192e/rtllib_softmac.c:1792:29: note: each undeclared identifier is reported only once for each function it appears in


vim +/ieee +1792 drivers/staging/rtl8192e/rtllib_softmac.c

1766
1767 static inline int auth_parse(struct net_device *dev, struct sk_buff *skb,
1768 u8 **challenge, int *chlen)
1769 {
1770 struct rtllib_authentication *a;
1771 u8 *t;
1772
1773 if (skb->len < (sizeof(struct rtllib_authentication) -
1774 sizeof(struct rtllib_info_element))) {
1775 netdev_dbg(dev, "invalid len in auth resp: %d\n", skb->len);
1776 return -EINVAL;
1777 }
1778 *challenge = NULL;
1779 a = (struct rtllib_authentication *) skb->data;
1780 if (skb->len > (sizeof(struct rtllib_authentication) + 3)) {
1781 t = skb->data + sizeof(struct rtllib_authentication);
1782
1783 if (*(t++) == MFIE_TYPE_CHALLENGE) {
1784 *chlen = *(t++);
1785 *challenge = kmemdup(t, *chlen, GFP_ATOMIC);
1786 if (!*challenge)
1787 return -ENOMEM;
1788 }
1789 }
1790
1791 if (a->status) {
> 1792 netdev_info(ieee->dev, "auth_parse() failed");
1793 return -EINVAL;
1794 }
1795
1796 return 0;
1797 }
1798

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-04-21 10:11    [W:0.074 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site