lkml.org 
[lkml]   [2022]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH V2 02/12] clk: mediatek: reset: Use simple reset operations
On Wed, Apr 20, 2022 at 9:05 PM Rex-BC Chen <rex-bc.chen@mediatek.com> wrote:
>
> There are two version for clock reset register control of MediaTek SoCs.
> The reset operations before MT8183 can use simple reset to cover.

I would go slightly into more detail, i.e.

The old hardware is one bit per reset control, and does not have
separate registers for bit set, clear and read-back operations. This
matches the scheme supported by the simple reset driver. ...

> Therefore, we replace mtk_reset_ops with reset_simple_ops.

... to remove redundant code.

The "why" is more important than "what" in commit logs. "What" you did
is already visible in the diff.

> In addition, we also rename mtk_register_reset_controller to
> mtk_register_reset_controller_simple.
>
> Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> ---
> drivers/clk/mediatek/Kconfig | 1 +
> drivers/clk/mediatek/clk-mt2701-eth.c | 2 +-
> drivers/clk/mediatek/clk-mt2701-g3d.c | 2 +-
> drivers/clk/mediatek/clk-mt2701-hif.c | 2 +-
> drivers/clk/mediatek/clk-mt2701.c | 4 +--
> drivers/clk/mediatek/clk-mt2712.c | 4 +--
> drivers/clk/mediatek/clk-mt7622-eth.c | 2 +-
> drivers/clk/mediatek/clk-mt7622-hif.c | 4 +--
> drivers/clk/mediatek/clk-mt7622.c | 4 +--
> drivers/clk/mediatek/clk-mt7629-eth.c | 2 +-
> drivers/clk/mediatek/clk-mt7629-hif.c | 4 +--
> drivers/clk/mediatek/clk-mt8135.c | 4 +--
> drivers/clk/mediatek/clk-mt8173.c | 4 +--
> drivers/clk/mediatek/clk-mtk.h | 6 ++--
> drivers/clk/mediatek/reset.c | 43 +++------------------------
> 15 files changed, 27 insertions(+), 61 deletions(-)

[...]

> void mtk_register_reset_controller_set_clr(struct device_node *np,
> unsigned int num_regs, int regofs)
> {
> mtk_register_reset_controller_common(np, num_regs, regofs,
> - &mtk_reset_ops_set_clr);
> + &mtk_reset_ops_set_clr);

This change is unrelated and should not be included.

ChenYu


> }
>
> MODULE_LICENSE("GPL");
> --
> 2.18.0
>

\
 
 \ /
  Last update: 2022-04-21 09:53    [W:0.181 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site