Messages in this thread | | | Date | Thu, 21 Apr 2022 09:24:20 +0200 | Subject | Re: [PATCH 3/4] KVM: s390: replace bitmap_copy with bitmap_{from,to}_arr64 where appropriate | From | David Hildenbrand <> |
| |
On 21.04.22 00:25, Yury Norov wrote: > Copying bitmaps from/to 64-bit arrays with bitmap_copy is not safe > in general case. Use designated functions instead. >
Just so I understand correctly: there is no BUG, it's just cleaner to do it that way, correct?
IIUC, bitmap_to_arr64() translates to bitmap_copy_clear_tail() on s390x.
As the passed length is always 1024 (KVM_S390_VM_CPU_FEAT_NR_BITS), we essentially end up with bitmap_copy() again.
Looks cleaner to me
Reviewed-by: David Hildenbrand <david@redhat.com>
-- Thanks,
David / dhildenb
| |