lkml.org 
[lkml]   [2022]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 5.10] fix csdlock_debug cause arm64 boot panic
From
Hi,

On 2022/4/21 12:08, Randy Dunlap wrote:
> Hi--
>
> On 4/20/22 20:39, Chen Zhongjin wrote:
>> ---
>> kernel/smp.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/smp.c b/kernel/smp.c
>> index 65a630f62363..1ce64de460d0 100644
>> --- a/kernel/smp.c
>> +++ b/kernel/smp.c
>> @@ -176,7 +176,7 @@ static int __init csdlock_debug(char *str)
>>
>> return 0;
>
> ^^^ This should be
> return 1;
>
> since __setup() functions return 1 on success -- opposite of
> early_param() return values.
>

Fixed in v2.

By the way, below patch forced to open CONFIG_SPARSEMEM_VMEMMAP on arm64
from 5.12-rc3. By this __page_to_pfn won't call __nr_to_section and
causes this bug.

https://lore.kernel.org/all/20210420093559.23168-1-catalin.marinas@arm.com/

So this patch is only applied to 5.10-LTS.

>> }
>> -early_param("csdlock_debug", csdlock_debug);
>> +__setup("csdlock_debug=", csdlock_debug);
>>
>> static DEFINE_PER_CPU(call_single_data_t *, cur_csd);
>> static DEFINE_PER_CPU(smp_call_func_t, cur_csd_func);
>
> Thanks.
>

Thanks!

\
 
 \ /
  Last update: 2022-04-21 09:22    [W:0.038 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site