lkml.org 
[lkml]   [2022]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/3] memblock tests: remove extra column of spaces in block comment
From
On 20.04.22 13:19, Rebecca Mckeever wrote:
> Remove extra space at the beginning of each line in block comment
> for consistency and to conform to Linux kernel coding style.
>
> Signed-off-by: Rebecca Mckeever <remckee0@gmail.com>
> ---
> tools/testing/memblock/tests/basic_api.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/tools/testing/memblock/tests/basic_api.c b/tools/testing/memblock/tests/basic_api.c
> index 834d8705ff8a..05448a25f1f9 100644
> --- a/tools/testing/memblock/tests/basic_api.c
> +++ b/tools/testing/memblock/tests/basic_api.c
> @@ -303,12 +303,12 @@ static int memblock_add_checks(void)
> return 0;
> }
>
> - /*
> - * A simple test that marks a memory block of a specified base address
> - * and size as reserved and to the collection of reserved memory regions
> - * (memblock.reserved). Expect to create a new entry. The region counter
> - * and total memory size are updated.
> - */
> +/*
> + * A simple test that marks a memory block of a specified base address
> + * and size as reserved and to the collection of reserved memory regions
> + * (memblock.reserved). Expect to create a new entry. The region counter
> + * and total memory size are updated.
> + */
> static int memblock_reserve_simple_check(void)
> {
> struct memblock_region *rgn;

I'd pull this patch to the front, so you don't end up modifying a wrong
style in patch #2. You could also just squash this patch into patch #2
and mention it in the patch description.

--
Thanks,

David / dhildenb

\
 
 \ /
  Last update: 2022-04-21 09:10    [W:2.271 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site