lkml.org 
[lkml]   [2022]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci warnings
From
On 21/04/2022 17:09, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
>
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:80:5-8: Unneeded variable: "ret". Return "0" on line 94
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:105:5-8: Unneeded variable: "ret". Return "0" on line 112
>
>
> Remove unneeded variable used to store return value.
>
> Generated by: scripts/coccinelle/misc/returnvar.cocci
>
> CC: Sandor Yu <Sandor.yu@nxp.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 65eb92e4c9f0a962656f131521f4fbc0d24c9d4c
> commit: d970ce303ff80ae57bbd3e784f2772dbf3056e0c [4441/5346] drm: bridge: dw_hdmi: Audio: Add General Parallel Audio (GPA) driver
> :::::: branch date: 8 hours ago
> :::::: commit date: 2 days ago
>
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
> @@ -77,7 +77,6 @@ static int audio_hw_params(struct device
> struct hdmi_codec_params *params)
> {
> struct snd_dw_hdmi *dw = dev_get_drvdata(dev);
> - int ret = 0;
> u8 ca;
>
> dw_hdmi_set_sample_rate(dw->data.hdmi, params->sample_rate);
> @@ -91,7 +90,7 @@ static int audio_hw_params(struct device
> params->iec.status[0] & IEC958_AES0_NONAUDIO);
> dw_hdmi_set_sample_width(dw->data.hdmi, params->sample_width);
>
> - return ret;
> + return 0;
> }
>
> static void audio_shutdown(struct device *dev, void *data)
> @@ -102,14 +101,13 @@ static int audio_mute_stream(struct devi
> bool enable, int direction)
> {
> struct snd_dw_hdmi *dw = dev_get_drvdata(dev);
> - int ret = 0;
>
> if (!enable)
> dw_hdmi_audio_enable(dw->data.hdmi);
> else
> dw_hdmi_audio_disable(dw->data.hdmi);
>
> - return ret;
> + return 0;
> }
>
> static int audio_get_eld(struct device *dev, void *data,

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

\
 
 \ /
  Last update: 2022-04-21 18:48    [W:0.057 / U:1.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site