lkml.org 
[lkml]   [2022]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v8 06/13] arm64: dts: freescale: Add i.MX8DXL evk board support
    From
    On 19/04/2022 13:35, Abel Vesa wrote:
    > From: Jacky Bai <ping.bai@nxp.com>
    >
    > Add i.MX8DXL EVK board support.
    >

    Thank you for your patch. There is something to discuss/improve.
    (...)

    > + /* global autoconfigured region for contiguous allocations */
    > + linux,cma {
    > + compatible = "shared-dma-pool";
    > + reusable;
    > + size = <0 0x14000000>;
    > + alloc-ranges = <0 0x98000000 0 0x14000000>;
    > + linux,cma-default;
    > + };
    > + };
    > +
    > + reg_usdhc2_vmmc: usdhc2-vmmc {

    usdhc2-vmmc-regulator or regulator-0

    (...)

    > +&thermal_zones {
    > + pmic-thermal0 {

    Are you sure this passes the dtbs_check?

    > + polling-delay-passive = <250>;
    > + polling-delay = <2000>;
    > + thermal-sensors = <&tsens IMX_SC_R_PMIC_0>;
    > +

    (...)

    > + pinctrl_usdhc1: usdhc1grp {
    > + fsl,pins = <
    > + IMX8DXL_EMMC0_CLK_CONN_EMMC0_CLK 0x06000041
    > + IMX8DXL_EMMC0_CMD_CONN_EMMC0_CMD 0x00000021
    > + IMX8DXL_EMMC0_DATA0_CONN_EMMC0_DATA0 0x00000021
    > + IMX8DXL_EMMC0_DATA1_CONN_EMMC0_DATA1 0x00000021
    > + IMX8DXL_EMMC0_DATA2_CONN_EMMC0_DATA2 0x00000021
    > + IMX8DXL_EMMC0_DATA3_CONN_EMMC0_DATA3 0x00000021
    > + IMX8DXL_EMMC0_DATA4_CONN_EMMC0_DATA4 0x00000021
    > + IMX8DXL_EMMC0_DATA5_CONN_EMMC0_DATA5 0x00000021
    > + IMX8DXL_EMMC0_DATA6_CONN_EMMC0_DATA6 0x00000021
    > + IMX8DXL_EMMC0_DATA7_CONN_EMMC0_DATA7 0x00000021
    > + IMX8DXL_EMMC0_STROBE_CONN_EMMC0_STROBE 0x00000041
    > + >;
    > + };
    > +
    > + pinctrl_usdhc1_100mhz: usdhc1grp100mhz {

    and this as well... I don't remember if we have schema for this but even
    without it, it breaks the convention. See other files.


    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2022-04-19 13:42    [W:2.745 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site