lkml.org 
[lkml]   [2022]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 064/219] media: rockchip/rga: do proper error checking in probe
    Date
    From: Kyle Copperfield <kmcopper@danwin1210.me>

    [ Upstream commit 6150f276073a1480030242a7e006a89e161d6cd6 ]

    The latest fix for probe error handling contained a typo that causes
    probing to fail with the following message:

    rockchip-rga: probe of ff680000.rga failed with error -12

    This patch fixes the typo.

    Fixes: e58430e1d4fd (media: rockchip/rga: fix error handling in probe)
    Reviewed-by: Dragan Simic <dragan.simic@gmail.com>
    Signed-off-by: Kyle Copperfield <kmcopper@danwin1210.me>
    Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
    Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/rockchip/rga/rga.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/platform/rockchip/rga/rga.c
    index 4de5e8d2b261..3d3d1062e212 100644
    --- a/drivers/media/platform/rockchip/rga/rga.c
    +++ b/drivers/media/platform/rockchip/rga/rga.c
    @@ -892,7 +892,7 @@ static int rga_probe(struct platform_device *pdev)
    }
    rga->dst_mmu_pages =
    (unsigned int *)__get_free_pages(GFP_KERNEL | __GFP_ZERO, 3);
    - if (rga->dst_mmu_pages) {
    + if (!rga->dst_mmu_pages) {
    ret = -ENOMEM;
    goto free_src_pages;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-04-18 14:21    [W:4.035 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site