lkml.org 
[lkml]   [2022]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 021/219] ALSA: als4000: Fix the missing snd_card_free() call at probe error
    Date
    From: Takashi Iwai <tiwai@suse.de>

    commit d616a0246da88d811f9f4c3aa83003c05efd3af0 upstream.

    The previous cleanup with devres may lead to the incorrect release
    orders at the probe error handling due to the devres's nature. Until
    we register the card, snd_card_free() has to be called at first for
    releasing the stuff properly when the driver tries to manage and
    release the stuff via card->private_free().

    This patch fixes it by calling snd_card_free() on the error from the
    probe callback using a new helper function.

    Fixes: 0e175f665960 ("ALSA: als4000: Allocate resources with device-managed APIs")
    Cc: <stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/20220412102636.16000-6-tiwai@suse.de
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    sound/pci/als4000.c | 10 ++++++++--
    1 file changed, 8 insertions(+), 2 deletions(-)

    --- a/sound/pci/als4000.c
    +++ b/sound/pci/als4000.c
    @@ -806,8 +806,8 @@ static void snd_card_als4000_free( struc
    snd_als4000_free_gameport(acard);
    }

    -static int snd_card_als4000_probe(struct pci_dev *pci,
    - const struct pci_device_id *pci_id)
    +static int __snd_card_als4000_probe(struct pci_dev *pci,
    + const struct pci_device_id *pci_id)
    {
    static int dev;
    struct snd_card *card;
    @@ -930,6 +930,12 @@ static int snd_card_als4000_probe(struct
    return 0;
    }

    +static int snd_card_als4000_probe(struct pci_dev *pci,
    + const struct pci_device_id *pci_id)
    +{
    + return snd_card_free_on_error(&pci->dev, __snd_card_als4000_probe(pci, pci_id));
    +}
    +
    #ifdef CONFIG_PM_SLEEP
    static int snd_als4000_suspend(struct device *dev)
    {

    \
     
     \ /
      Last update: 2022-04-18 14:17    [W:3.424 / U:0.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site