Messages in this thread Patch in this message | | | From | Grant Grundler <> | Subject | [PATCH 1/5] net: atlantic: limit buff_ring index value | Date | Mon, 18 Apr 2022 16:17:42 -0700 |
| |
buff->next is pulled from data DMA'd by the NIC and later used to index into the buff_ring[] array. Verify the index is within the size of the array.
Reported-by: Aashay Shringarpure <aashay@google.com> Reported-by: Yi Chou <yich@google.com> Reported-by: Shervin Oloumi <enlightened@google.com> Signed-off-by: Grant Grundler <grundler@chromium.org> --- drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c index d875ce3ec759..e72b9d86f6ad 100644 --- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c +++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c @@ -981,7 +981,9 @@ int hw_atl_b0_hw_ring_rx_receive(struct aq_hw_s *self, struct aq_ring_s *ring) if (buff->is_lro) { /* LRO */ - buff->next = rxd_wb->next_desc_ptr; + buff->next = + (rxd_wb->next_desc_ptr < ring->size) ? + rxd_wb->next_desc_ptr : 0U; ++ring->stats.rx.lro_packets; } else { /* jumbo */ -- 2.36.0.rc0.470.gd361397f0d-goog
| |