lkml.org 
[lkml]   [2022]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 RESEND 6/9] serial: max310: remove redundant memset in rs485_config
    Date
    In uart_set_rs485_config() the serial core already nullifies the padding
    field of the passed serial_rs485 struct before returning it to userspace.

    Doing the same in the drivers rs485_config() function is redundant, so
    remove the concerning memset in this function.

    Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
    ---
    drivers/tty/serial/max310x.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c
    index 3112b4a05448..a0b6ea52d133 100644
    --- a/drivers/tty/serial/max310x.c
    +++ b/drivers/tty/serial/max310x.c
    @@ -1037,7 +1037,6 @@ static int max310x_rs485_config(struct uart_port *port,

    rs485->flags &= SER_RS485_RTS_ON_SEND | SER_RS485_RX_DURING_TX |
    SER_RS485_ENABLED;
    - memset(rs485->padding, 0, sizeof(rs485->padding));
    port->rs485 = *rs485;

    schedule_work(&one->rs_work);
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-04-10 12:48    [W:2.229 / U:0.436 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site