Messages in this thread | | | From | <> | Subject | Re: [PATCH] ASoC: atmel: mchp-pdmc: Fix `-Wpointer-bool-conversion` warning | Date | Wed, 9 Mar 2022 07:55:01 +0000 |
| |
On 09.03.2022 08:58, Alviro Iskandar Setiawan wrote: > In function mchp_pdmc_af_put(), Intel's kernel test robot reports the > following warning: > > sound/soc/atmel/mchp-pdmc.c:186:34: warning: address of array \ > 'uvalue->value.integer.value' will always evaluate to 'true' \ > [-Wpointer-bool-conversion] > > This is because we are using `uvalue->value.integer.value` which its > type is `long value[128];` for conditional expression and that array > will always decay to a non-NULL pointer. Using a non-NULL pointer for > conditional expression will always evaluate to true. > > Fix this by changing it to `uvalue->value.integer.value[0]` as that's > what the mchp_pdmc_af_get() function sets. > > To: Mark Brown <broonie@kernel.org> > Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> > Cc: Nugraha <richiisei@gmail.com> > Cc: llvm@lists.linux.dev > Cc: kbuild-all@lists.01.org > Cc: gwml@vger.gnuweeb.org > Cc: linux-kernel@vger.kernel.org > Reported-by: kernel test robot <lkp@intel.com> > Link: https://lore.kernel.org/lkml/202203091430.MLY27Bif-lkp@intel.com > Fixes: 50291652af5269813baa6024eb0e81b5f0bbb451 ("ASoC: atmel: mchp-pdmc: add PDMC driver") > Signed-off-by: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Thank you!
| |