lkml.org 
[lkml]   [2022]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 05/11] pinctrl: mediatek: paris: Drop extra newline in mtk_pctrl_show_one_pin()
From
Date
On Tue, 2022-03-08 at 18:09 +0800, Chen-Yu Tsai wrote:
> The caller of mtk_pctrl_show_one_pin() is responsible for printing the
> full line. mtk_pctrl_show_one_pin(), called through mtk_pctrl_dbg_show(),
> should only produce a string containing the extra information the driver
> wants included.

Does this function have another caller?

It looks as if this function doesn't need to be EXPORT_SYMBOL_GPL
and could just be declared static in the file instead.

btw: using %1d is mostly senseless as a control, but has some
documentary use as a value < 0 or >= 10 will be always be
fully emitted anyway.

> diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c
[]
> @@ -634,14 +634,10 @@ ssize_t mtk_pctrl_show_one_pin(struct mtk_pinctrl *hw,
> pullen,
> pullup);
>
> - if (r1 != -1) {
> - len += scnprintf(buf + len, buf_len - len, " (%1d %1d)\n",
> - r1, r0);
> - } else if (rsel != -1) {
> - len += scnprintf(buf + len, buf_len - len, " (%1d)\n", rsel);
> - } else {
> - len += scnprintf(buf + len, buf_len - len, "\n");
> - }
> + if (r1 != -1)
> + len += scnprintf(buf + len, buf_len - len, " (%1d %1d)", r1, r0);
> + else if (rsel != -1)
> + len += scnprintf(buf + len, buf_len - len, " (%1d)", rsel);
>
> return len;
> }


\
 
 \ /
  Last update: 2022-03-09 21:02    [W:0.210 / U:0.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site