Messages in this thread | | | Subject | Re: [PATCH v2 02/19] netfs: Generate enums from trace symbol mapping lists | From | Jeff Layton <> | Date | Wed, 09 Mar 2022 13:39:08 -0500 |
| |
On Wed, 2022-03-09 at 15:49 +0000, David Howells wrote: > Jeff Layton <jlayton@redhat.com> wrote: > > > Should you undef EM and E_ here after creating these? > > Maybe. So far it hasn't mattered... >
I wasn't suggesting there was a bug there, more just a code hygiene thing. With macro names as generic as that (especially), it'd probably be good to undef them once you're done. -- Jeff Layton <jlayton@redhat.com>
| |