Messages in this thread | | | From | Masahiro Yamada <> | Date | Tue, 8 Mar 2022 13:01:45 +0900 | Subject | Re: [PATCH v4] config: Allow kernel installation packaging to override pkg-config |
| |
On Tue, Mar 8, 2022 at 7:50 AM Chun-Tse Shao <ctshao@google.com> wrote: > > On Mon, Mar 07, 2022 at 10:17:17AM -0800, Nick Desaulniers wrote: > > On Sun, Mar 6, 2022 at 2:39 PM Chun-Tse Shao <ctshao@google.com> wrote: > > > > > > Add HOSTPKG_CONFIG to allow tooling that builds the kernel to override > > > what pkg-config and parameters are used. > > > > Sorry, kind a late thought here for v4, but we don't seem to prefix > > many other host side tools with HOST_, i.e. LEX, YACC, AWK, PERL, > > PYTHON3, etc. Maybe just having the variable identifier be simply > > PKGCONFIG rather than HOSTPKG_CONFIG then put it at the end of the > > list in the top level Makefile after ZSTD (i.e. the list of host > > tools)? There's HOST_ prefixes when there's more than one tool > > involved (i.e. host compiler vs target compiler), but I suspect > > there's no such distinction for the existing uses of pkg-config? > > > Thanks for your suggestion, Nick! Yes I think it makes sense with PKGCONFIG > instead of HOSTPKG_CONFIG since there is only one tool involved. I will > work on it and submit a new patch. >
Please hold on.
I was also wondering what to do with the "HOST" prefix.
Libraries are usually arch-dependent. (in other words, pkg-config should return different library paths for $(CC) and $(HOSTCC) )
You already understood this, so you added "HOST" prefix.
Please let me take time for further discussion. I will come back to this when I get some time.
In the meantime, a8a5cd8b472ca20e5b8fa649c43b3756867322f8 as reference info if you have not seen it.
How many distros support something like "aarch64-linux-gnu-pkg-config" ?
Ubuntu 18.04 and 20.04 seem to support it. I do not know for others.
-- Best Regards
Masahiro Yamada
| |