lkml.org 
[lkml]   [2022]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/5] powerpc/83xx: fix possible object reference leak
    From


    Le 22/03/2019 à 04:05, Wen Yang a écrit :
    > The call to of_find_node_by_name returns a node pointer with refcount
    > incremented thus it must be explicitly decremented after the last
    > usage.
    >
    > Detected by coccinelle with the following warnings:
    > ./arch/powerpc/platforms/83xx/km83xx.c:68:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 59, but without a corresponding object release within this function.

    This was fixed by
    https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id=88654d5b4476

    >
    > Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
    > Cc: Scott Wood <oss@buserror.net>
    > Cc: Kumar Gala <galak@kernel.crashing.org>
    > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    > Cc: Paul Mackerras <paulus@samba.org>
    > Cc: Michael Ellerman <mpe@ellerman.id.au>
    > Cc: linuxppc-dev@lists.ozlabs.org
    > Cc: linux-kernel@vger.kernel.org
    > ---
    > arch/powerpc/platforms/83xx/km83xx.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/arch/powerpc/platforms/83xx/km83xx.c b/arch/powerpc/platforms/83xx/km83xx.c
    > index d8642a4..11eea7c 100644
    > --- a/arch/powerpc/platforms/83xx/km83xx.c
    > +++ b/arch/powerpc/platforms/83xx/km83xx.c
    > @@ -65,6 +65,7 @@ static void quirk_mpc8360e_qe_enet10(void)
    > ret = of_address_to_resource(np_par, 0, &res);
    > if (ret) {
    > pr_warn("%s couldn;t map par_io registers\n", __func__);
    > + of_node_put(np_par);
    > return;
    > }
    >

    \
     
     \ /
      Last update: 2022-03-27 09:09    [W:5.604 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site