lkml.org 
[lkml]   [2022]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] dt-bindings: gpio: add common consumer GPIO lines
On Sat, 26 Mar 2022 at 01:28, Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Tue, Mar 15, 2022 at 9:37 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>
> > Typical GPIO lines like enable, powerdown, reset or wakeup are not
> > documented as common, which leads to new variations of these (e.g.
> > pwdn-gpios). Add a common schema which serves also as a documentation
> > for preferred naming.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
> I like the idea!
>
> > + enable-gpios:
> > + $ref: /schemas/types.yaml#/definitions/phandle-array
> > +
> > + reset-gpios:
> > + $ref: /schemas/types.yaml#/definitions/phandle-array
> > +
> > + powerdown-gpios:
> > + $ref: /schemas/types.yaml#/definitions/phandle-array
> > +
> > + pwdn-gpios:
> > + $ref: /schemas/types.yaml#/definitions/phandle-array
> > + description: Use powerdown-gpios
> > + deprecated: true
> > +
> > + wakeup-gpios:
> > + $ref: /schemas/types.yaml#/definitions/phandle-array
>
> I would underscore either on each one or in a global description:
> that lines on components that indicate they are active low
> such as RESETN, RESET* etc MUST have the flag in the
> second cell set to GPIO_ACTIVE_LOW.

Sure, I'll add it.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-03-26 09:06    [W:0.082 / U:1.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site