Messages in this thread | | | Subject | Re: [PATCH 2/3] block: factor out common code for part_stat_show() and diskstats_show() | From | "yukuai (C)" <> | Date | Sat, 26 Mar 2022 09:11:36 +0800 |
| |
在 2022/03/25 16:46, Christoph Hellwig 写道: > On Thu, Mar 17, 2022 at 07:26:52PM +0800, Yu Kuai wrote: >> part_stat_show() and diskstats_show() are very similar, just factor out >> common code. > > Well, it doesn't really "factor" much, but creates a big and pretty > unmaintainble macro. I don't really see the benefit here.
Hi,
Thanks for your advice, I'll remove this patch.
BTW, do you have any suggestion about patch 3 ?
Thanks, Kuai > . >
| |