lkml.org 
[lkml]   [2022]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 64/64] media: Kconfig: cleanup VIDEO_DEV dependencies
    From
    Date
    On 3/14/22 1:55 AM, Mauro Carvalho Chehab wrote:
    > media Kconfig has two entries associated to V4L API:
    > VIDEO_DEV and VIDEO_V4L2.
    >
    > On Kernel 2.6.x, there were two V4L APIs, each one with its own flag.
    > VIDEO_DEV were meant to:
    > 1) enable Video4Linux and make its Kconfig options to appear;
    > 2) it makes the Kernel build the V4L core.
    >
    > while VIDEO_V4L2 where used to distinguish between drivers that
    > implement the newer API and drivers that implemented the former one.
    >
    > With time, such meaning changed, specially after the removal of
    > all V4L version 1 drivers.
    >
    > At the current implementation, VIDEO_DEV only does (1): it enables
    > the media options related to V4L, that now has:
    >
    > menu "Video4Linux options"
    > visible if VIDEO_DEV
    >
    > source "drivers/media/v4l2-core/Kconfig"
    > endmenu
    >
    > but it doesn't affect anymore the V4L core drivers.
    >
    > The rationale is that the V4L2 core has a "soft" dependency
    > at the I2C bus, and now requires to select a number of other
    > Kconfig options:
    >
    > config VIDEO_V4L2
    > tristate
    > depends on (I2C || I2C=n) && VIDEO_DEV
    > select RATIONAL
    > select VIDEOBUF2_V4L2 if VIDEOBUF2_CORE
    > default (I2C || I2C=n) && VIDEO_DEV
    >
    > In the past, merging them would be tricky, but it seems that it is now
    > possible to merge those symbols, in order to simplify V4L dependencies.
    >
    > Let's keep VIDEO_DEV, as this one is used on some make *defconfig
    > configurations.
    >
    > Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    > Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
    > ---
    >

    > drivers/media/test-drivers/vicodec/Kconfig | 2 +-
    > drivers/media/test-drivers/vimc/Kconfig | 2 +-
    > drivers/media/test-drivers/vivid/Kconfig | 2 +-
    >

    For vimc change: (trimmed the recipient list to send response)

    Acked-by: Shuah Khan <skhan@linuxfoundation.org>

    thanks,
    -- Shuah



    \
     
     \ /
      Last update: 2022-03-18 21:59    [W:4.088 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site