lkml.org 
[lkml]   [2022]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: [PATCH 5.4 21/43] selftests/bpf: Add test for bpf_timer overwriting crash
    Date
    On Mon, 2022-03-14 at 12:53 +0100, Greg Kroah-Hartman wrote:
    > From: Kumar Kartikeya Dwivedi <memxor@gmail.com>
    >
    > [ Upstream commit a7e75016a0753c24d6c995bc02501ae35368e333 ]
    >
    > Add a test that validates that timer value is not overwritten when doing
    > a copy_map_value call in the kernel. Without the prior fix, this test
    > triggers a crash.
    >
    > Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
    > Signed-off-by: Alexei Starovoitov <ast@kernel.org>
    > Link: https://lore.kernel.org/bpf/20220209070324.1093182-3-memxor@gmail.com
    > Signed-off-by: Sasha Levin <sashal@kernel.org>

    Hi, this patch in 5.4.185 breaks bpf selftests build for me:

    progs/timer_crash.c:3:10: fatal error: 'vmlinux.h' file not found
    #include <vmlinux.h>
    ^~~~~~~~~~~

    Based on quick look, vmlinux.h generation was added to selftests in v5.7,
    so drop this patch in v5.4?

    -Tommi


    > ---
    > .../selftests/bpf/prog_tests/timer_crash.c | 32 +++++++++++
    > .../testing/selftests/bpf/progs/timer_crash.c | 54 +++++++++++++++++++
    > 2 files changed, 86 insertions(+)
    > create mode 100644 tools/testing/selftests/bpf/prog_tests/timer_crash.c
    > create mode 100644 tools/testing/selftests/bpf/progs/timer_crash.c
    >
    > diff --git a/tools/testing/selftests/bpf/progs/timer_crash.c b/tools/testing/selftests/bpf/progs/timer_crash.c
    > new file mode 100644
    > index 000000000000..f8f7944e70da
    > --- /dev/null
    > +++ b/tools/testing/selftests/bpf/progs/timer_crash.c
    > @@ -0,0 +1,54 @@
    > +// SPDX-License-Identifier: GPL-2.0
    > +
    > +#include <vmlinux.h>
    > +#include <bpf/bpf_tracing.h>
    > +#include <bpf/bpf_helpers.h>
    > +
    \
     
     \ /
      Last update: 2022-03-18 08:29    [W:4.782 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site