Messages in this thread | | | Date | Fri, 18 Mar 2022 09:14:40 +0000 | Subject | Re: [PATCH 1/8] perf vendor events: Update events for CascadelakeX | From | John Garry <> |
| |
On 17/03/2022 18:28, Ian Rogers wrote: > The change: > https://github.com/intel/event-converter-for-linux-perf/commit/fc680410402e394eed6a1ebd909c9f649d3ed3ef > moved certain "other" type of events in to the cache topic. Update the > perf json files for this change. > > Tested: > ``` > ... > 6: Parse event definition strings : Ok > 7: Simple expression parser : Ok > 8: PERF_RECORD_* events & perf_sample fields : Ok > 9: Parse perf pmu format : Ok > 10: PMU events : > 10.1: PMU event table sanity : Ok > 10.2: PMU event map aliases : Ok > 10.3: Parsing of PMU event table metrics : Ok > 10.4: Parsing of PMU event table metrics with fake PMUs : Ok > ... > 68: Parse and process metrics : Ok > ... > 89: perf all metricgroups test : Ok > 90: perf all metrics test : FAILED! > 91: perf all PMU test : Ok > ... > ``` > > Test 90 failed due to MEM_PMM_Read_Latency as the test machine > lacks optane memory, and the divide by 0 causes the metric not to > print - which is intended behavior.
Hi Ian,
Failing is not ideal as an intended/expected behaviour. Could we make the test skip somehow for the case you describe?
Thanks, John
| |