lkml.org 
[lkml]   [2022]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 04/22] cachefiles: notify user daemon with anon_fd when looking up cookie
    Hi Jeffle,

    Thank you for the patch! Yet something to improve:

    [auto build test ERROR on trondmy-nfs/linux-next]
    [also build test ERROR on rostedt-trace/for-next linus/master v5.17-rc8]
    [cannot apply to xiang-erofs/dev-test dhowells-fs/fscache-next next-20220316]
    [If your patch is applied to the wrong git tree, kindly drop us a note.
    And when submitting patch, we suggest to use '--base' as documented in
    https://git-scm.com/docs/git-format-patch]

    url: https://github.com/0day-ci/linux/commits/Jeffle-Xu/fscache-erofs-fscache-based-on-demand-read-semantics/20220316-214711
    base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
    config: ia64-randconfig-r033-20220317 (https://download.01.org/0day-ci/archive/20220317/202203170323.idYrKxCZ-lkp@intel.com/config)
    compiler: ia64-linux-gcc (GCC) 11.2.0
    reproduce (this is a W=1 build):
    wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
    chmod +x ~/bin/make.cross
    # https://github.com/0day-ci/linux/commit/ef29cbdc09ec1e6ab918eaf5a16fa7ba8d23fb54
    git remote add linux-review https://github.com/0day-ci/linux
    git fetch --no-tags linux-review Jeffle-Xu/fscache-erofs-fscache-based-on-demand-read-semantics/20220316-214711
    git checkout ef29cbdc09ec1e6ab918eaf5a16fa7ba8d23fb54
    # save the config file to linux build tree
    mkdir build_dir
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash fs/cachefiles/

    If you fix the issue, kindly add following tag as appropriate
    Reported-by: kernel test robot <lkp@intel.com>

    All errors (new ones prefixed by >>):

    In file included from arch/ia64/include/asm/pgtable.h:153,
    from include/linux/pgtable.h:6,
    from arch/ia64/include/asm/uaccess.h:40,
    from include/linux/uaccess.h:11,
    from include/linux/sched/task.h:11,
    from include/linux/sched/signal.h:9,
    from include/linux/rcuwait.h:6,
    from include/linux/percpu-rwsem.h:7,
    from include/linux/fs.h:33,
    from fs/cachefiles/daemon.c:13:
    arch/ia64/include/asm/mmu_context.h: In function 'reload_context':
    arch/ia64/include/asm/mmu_context.h:127:48: warning: variable 'old_rr4' set but not used [-Wunused-but-set-variable]
    127 | unsigned long rr0, rr1, rr2, rr3, rr4, old_rr4;
    | ^~~~~~~
    fs/cachefiles/daemon.c: In function 'cachefiles_ondemand_fd_write_iter':
    >> fs/cachefiles/daemon.c:160:26: error: invalid use of undefined type 'struct iov_iter'
    160 | size_t len = iter->count;
    | ^~


    vim +160 fs/cachefiles/daemon.c

    153
    154 static ssize_t cachefiles_ondemand_fd_write_iter(struct kiocb *kiocb,
    155 struct iov_iter *iter)
    156 {
    157 struct cachefiles_object *object = kiocb->ki_filp->private_data;
    158 struct cachefiles_cache *cache = object->volume->cache;
    159 struct file *file = object->file;
    > 160 size_t len = iter->count;
    161 loff_t pos = kiocb->ki_pos;
    162 const struct cred *saved_cred;
    163 int ret;
    164
    165 if (!file)
    166 return -ENOBUFS;
    167
    168 cachefiles_begin_secure(cache, &saved_cred);
    169 ret = __cachefiles_prepare_write(object, file, &pos, &len, true);
    170 cachefiles_end_secure(cache, saved_cred);
    171 if (ret < 0)
    172 return ret;
    173
    174 ret = __cachefiles_write(object, file, pos, iter, NULL, NULL);
    175 if (!ret)
    176 ret = len;
    177
    178 return ret;
    179 }
    180

    ---
    0-DAY CI Kernel Test Service
    https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

    \
     
     \ /
      Last update: 2022-03-16 20:39    [W:2.878 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site