Messages in this thread | | | Date | Tue, 15 Mar 2022 15:19:09 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v2 2/2] staging: r8188eu: proper error handling in rtw_init_drv_sw |
| |
On Thu, Mar 10, 2022 at 02:20:47AM +0530, Vihas Makwana wrote: > The code inside rtw_init_drv_sw() calls various init functions to > populate the padapter structure and checks for their return values > respectively. > But if one of the functions in middle fails then it simply returns > _FAIL instead of proper logging and calling freeing counterparts > of previous init functions. > This leads to various memory leaks and can be found in > /sys/kernel/debug/kmemleak if kernel is compiled with DEBUG_KMEMLEAK=y. > > Fix this and keep the success and error separate. > > Fixes: 2b42bd58b321 ("staging: r8188eu: introduce new os_dep dir for > RTL8188eu driver")
Nit, that needed to be on one line, and no blank line before the next ones.
I've fixed it up now.
thanks,
greg k-h
| |