lkml.org 
[lkml]   [2022]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 10/43] net: ethernet: lpc_eth: Handle error for clk_enable
    Date
    From: Jiasheng Jiang <jiasheng@iscas.ac.cn>

    [ Upstream commit 2169b79258c8be803d2595d6456b1e77129fe154 ]

    As the potential failure of the clk_enable(),
    it should be better to check it and return error
    if fails.

    Fixes: b7370112f519 ("lpc32xx: Added ethernet driver")
    Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/nxp/lpc_eth.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c
    index 3b177421651f..d2e220a94a57 100644
    --- a/drivers/net/ethernet/nxp/lpc_eth.c
    +++ b/drivers/net/ethernet/nxp/lpc_eth.c
    @@ -1470,6 +1470,7 @@ static int lpc_eth_drv_resume(struct platform_device *pdev)
    {
    struct net_device *ndev = platform_get_drvdata(pdev);
    struct netdata_local *pldat;
    + int ret;

    if (device_may_wakeup(&pdev->dev))
    disable_irq_wake(ndev->irq);
    @@ -1479,7 +1480,9 @@ static int lpc_eth_drv_resume(struct platform_device *pdev)
    pldat = netdev_priv(ndev);

    /* Enable interface clock */
    - clk_enable(pldat->clk);
    + ret = clk_enable(pldat->clk);
    + if (ret)
    + return ret;

    /* Reset and initialize */
    __lpc_eth_reset(pldat);
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-03-14 12:57    [W:2.940 / U:0.944 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site