Messages in this thread | | | From | HORIGUCHI NAOYA(堀口 直也) <> | Subject | Re: [PATCH v2 3/3] mm/memory-failure.c: make non-LRU movable pages unhandlable | Date | Sun, 13 Mar 2022 23:43:42 +0000 |
| |
On Sat, Mar 12, 2022 at 03:46:13PM +0800, Miaohe Lin wrote: > We can not really handle non-LRU movable pages in memory failure. Typically > they are balloon, zsmalloc, etc. Assuming we run into a base (4K) non-LRU > movable page, we could reach as far as identify_page_state(), it should not > fall into any category except me_unknown. For the non-LRU compound movable > pages, they could be taken for transhuge pages but it's unexpected to split > non-LRU movable pages using split_huge_page_to_list in memory_failure. So > we could just simply make non-LRU movable pages unhandlable to avoid these > possible nasty cases. > > Suggested-by: Yang Shi <shy828301@gmail.com> > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Looks good to me.
Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com> | |