Messages in this thread | | | Date | Tue, 8 Feb 2022 19:22:03 +0100 | From | Sam Ravnborg <> | Subject | Re: [PATCH 10/21] fb: Delete fb_info->queue |
| |
Hi Daniel,
On Tue, Feb 08, 2022 at 02:46:33PM +0100, Daniel Vetter wrote: > On Thu, Feb 03, 2022 at 10:31:00PM +0100, Sam Ravnborg wrote: > > On Mon, Jan 31, 2022 at 10:05:41PM +0100, Daniel Vetter wrote: > > > It was only used by fbcon, and that now switched to its own, > > > private work. > > > > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > > Cc: Helge Deller <deller@gmx.de> > > > Cc: linux-fbdev@vger.kernel.org > > I would merge this with the patch that drops the usage > > Yeah, but I like to split these out so that if this does break something, > it's much easier to revert. In case I overlooked something somewhere. > > It's imo different if the cleanup is directly related to the preceeding > prep work, but this is a generic workqueue, and the cursor logic is rather > unrelated. And if I remember my history digging right, there were actually > other uses of this.
So you basically say that because in the past there may have been other users, this deserves a dedicated removal commit.
That works for me too. Acked-by: Sam Ravnborg <sam@ravnborg.org>
Sam
| |