Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH net v2] net: phy: marvell: Fix RGMII Tx/Rx delays setting in 88e1121-compatible PHYs | From | patchwork-bot+netdevbpf@kernel ... | Date | Tue, 08 Feb 2022 04:10:08 +0000 |
| |
Hello:
This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>:
On Sat, 5 Feb 2022 23:39:32 +0300 you wrote: > It is mandatory for a software to issue a reset upon modifying RGMII > Receive Timing Control and RGMII Transmit Timing Control bit fields of MAC > Specific Control register 2 (page 2, register 21) otherwise the changes > won't be perceived by the PHY (the same is applicable for a lot of other > registers). Not setting the RGMII delays on the platforms that imply it' > being done on the PHY side will consequently cause the traffic loss. We > discovered that the denoted soft-reset is missing in the > m88e1121_config_aneg() method for the case if the RGMII delays are > modified but the MDIx polarity isn't changed or the auto-negotiation is > left enabled, thus causing the traffic loss on our platform with Marvell > Alaska 88E1510 installed. Let's fix that by issuing the soft-reset if the > delays have been actually set in the m88e1121_config_aneg_rgmii_delays() > method. > > [...]
Here is the summary with links: - [net,v2] net: phy: marvell: Fix RGMII Tx/Rx delays setting in 88e1121-compatible PHYs https://git.kernel.org/netdev/net/c/fe4f57bf7b58
You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
| ![\](/images/icornerr.gif) |