lkml.org 
[lkml]   [2022]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4 12/12] arm64: dts: freescale: add initial support for verdin imx8m mini
Hi Marcel,

On Fri, Feb 4, 2022 at 7:58 PM Marcel Ziswiler <marcel@ziswiler.com> wrote:

> +/* On-module Wi-Fi */
> +&usdhc3 {
> + bus-width = <4>;
> + keep-power-in-suspend;
> + non-removable;
> + pinctrl-names = "default", "state_100mhz", "state_200mhz";
> + pinctrl-0 = <&pinctrl_usdhc3>, <&pinctrl_wifi_ctrl>;
> + pinctrl-1 = <&pinctrl_usdhc3_100mhz>, <&pinctrl_wifi_ctrl>;
> + pinctrl-2 = <&pinctrl_usdhc3_200mhz>, <&pinctrl_wifi_ctrl>;
> + vmmc-supply = <&reg_wifi_en>;
> + wifi-host;

wifi-host is not a valid property.

> + /* Use the kernel configuration settings instead */
> + /delete-node/ linux,cma;
> +
> + rpmsg_reserved: rpmsg@b8000000 {

I suppose this comes from the NXP vendor BSP and does not apply upstream.

> +/* Verdin CAN_1 (On-module) */
> +&ecspi3 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + cs-gpios = <&gpio5 25 GPIO_ACTIVE_LOW>,
> + <&gpio1 5 GPIO_ACTIVE_LOW>;
> + spi-num-chipselects = <2>;

No need to specify "spi-num-chipselects". It is implicit by cs-gpios.

> +
> +&usbmisc1 {
> + vbus-wakeup-supply = <&reg_vdd_3v3>;

Not a valid property.

> +};
> +
> +&usbmisc2 {
> + vbus-wakeup-supply = <&reg_vdd_3v3>;

Ditto.

> +};
> +
> +/* Verdin USB_1 */
> +&usbotg1 {
> + adp-disable;
> + dr_mode = "otg";
> + hnp-disable;
> + over-current-active-low;
> + picophy,dc-vol-level-adjust = <7>;

I guess you meant: samsung,picophy-dc-vol-level-adjust

> + picophy,pre-emp-curr-control = <3>;

I guess you meant: samsung,picophy-pre-emp-curr-control

> +&usbotg2 {
> + dr_mode = "host";
> + over-current-active-low;
> + picophy,dc-vol-level-adjust = <7>;
> + picophy,pre-emp-curr-control = <3>;

Same here.

\
 
 \ /
  Last update: 2022-02-07 21:50    [W:0.116 / U:1.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site