Messages in this thread | | | Date | Fri, 4 Feb 2022 09:18:04 +0100 | Subject | Re: [PATCH] arm64: dts: meson-sm1-odroid: fix boot loop after reboot | From | Neil Armstrong <> |
| |
Hi,
On 28/01/2022 20:31, Lutz Koschorreck wrote: > Since the correct gpio pin is used for enabling tf-io regulator the > system did not boot correctly after calling reboot. > > [ 36.862443] reboot: Restarting system > bl31 reboot reason: 0xd > bl31 reboot reason: 0x0 > system cmd 1. > SM1:BL:511f6b:81ca2f;FEAT:A0F83180:20282000;POC:B;RCY:0;SPINOR:0;CHK:1F;EMMC:800;NAND:81;SD?:0;SD:0;READ:0;0.0;CHK:0; > bl2_stage_init 0x01 > bl2_stage_init 0x81 > hw id:▒SM1:BL:511f6b:81ca2f;FEAT:A0F83180:20282000;POC:B;RCY:0;SPINOR:0;CHK:1F;EMMC:800;NAND:81;SD?:0;SD:400;USB:8;LOOP:1;SPINOR:0;CHK:1F;EMMC:800;NAND:81;SD?:0;SD:400;USB:8;LOOP:2;SPINOR:0;CHK:1F;EMMC:800;NAND:81;SD?:0;SD:400;USB:8;LOOP:3;SPINOR:0;CHK:1F;EMMC:800;NAND:81;SD?:0;SD:400;USB:8;LOOP:4;SPINOR:0;CHK:1F;EMMC:800;NAND:81;SD?:0;SD:400;USB:8;LOOP:5;SPINOR:0;CHK:1F;EMMC:800;NAND:81;SD?:0;SD:400;USB:8; > > Setting the gpio to open drain solves the issue. >
Fixes: 1f80a5cf74a6 ("arm64: dts: meson-sm1-odroid: add missing enable gpio and supply for tf_io regulator")
> Signed-off-by: Lutz Koschorreck <theleks@ko-hh.de> > --- > arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi > index ed7cd5f53046..ddb1b345397f 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi > @@ -48,7 +48,7 @@ tf_io: gpio-regulator-tf_io { > regulator-max-microvolt = <3300000>; > vin-supply = <&vcc_5v>; > > - enable-gpio = <&gpio_ao GPIOE_2 GPIO_ACTIVE_HIGH>; > + enable-gpio = <&gpio_ao GPIOE_2 GPIO_OPEN_DRAIN>; > enable-active-high; > regulator-always-on; >
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
| |