Messages in this thread | | | Date | Fri, 4 Feb 2022 16:04:07 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH] printk: defer_console_output: do not assume interrupts disabled |
| |
On (22/02/03 12:35), John Ogness wrote: > With commit 458df9fd4815 ("printk: remove separate printk_sched > buffers and use printk buf instead") defer_console_output() was > changed to no longer disable interrupts. However, it used the > function __this_cpu_or(), which assumes interrupts disabled. That > also should have been changed to this_cpu_or(). > > Although defer_console_output() is mostly used when interrupts are > disabled, this is not always the case. One example is > get_random_bytes(), which is often called with interrupts enabled. > > get_random_bytes() > warn_unseeded_randomness() > printk_deferred() > > Reported-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
| |