Messages in this thread | | | Date | Fri, 4 Feb 2022 13:52:39 -0800 | From | Luis Chamberlain <> | Subject | Re: [PATCH v1] printk: Fix incorrect __user type in proc_dointvec_minmax_sysadmin() |
| |
On Fri, Feb 04, 2022 at 12:09:55PM +0900, Sergey Senozhatsky wrote: > On (22/02/03 15:50), Mickaël Salaün wrote: > > The move of proc_dointvec_minmax_sysadmin() from kernel/sysctl.c to > > kernel/printk/sysctl.c introduced an incorrect __user attribute to the > > buffer argument. I spotted this change in [1] as well as the kernel > > test robot. Revert this change to please sparse: > > > > kernel/printk/sysctl.c:20:51: warning: incorrect type in argument 3 (different address spaces) > > kernel/printk/sysctl.c:20:51: expected void * > > kernel/printk/sysctl.c:20:51: got void [noderef] __user *buffer > > > > Fixes: faaa357a55e0 ("printk: move printk sysctl to printk/sysctl.c") > > Link: https://lore.kernel.org/r/20220104155024.48023-2-mic@digikod.net [1] > > Reported-by: kernel test robot <lkp@intel.com> > > Cc: Andrew Morton <akpm@linux-foundation.org> > > Cc: John Ogness <john.ogness@linutronix.de> > > Cc: Linus Torvalds <torvalds@linux-foundation.org> > > Cc: Luis Chamberlain <mcgrof@kernel.org> > > Cc: Petr Mladek <pmladek@suse.com> > > Cc: Sergey Senozhatsky <senozhatsky@chromium.org> > > Cc: Steven Rostedt <rostedt@goodmis.org> > > Cc: Xiaoming Ni <nixiaoming@huawei.com> > > Signed-off-by: Mickaël Salaün <mic@linux.microsoft.com> > > Link: https://lore.kernel.org/r/20220203145029.272640-1-mic@digikod.net > > Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Luis
| |