Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 28 Feb 2022 00:32:23 -0800 | From | Zev Weiss <> | Subject | Re: [PATCH 3/5] hwmon: (nct6775) Split core and platform driver |
| |
On Sun, Feb 27, 2022 at 07:44:47AM PST, Guenter Roeck wrote: >On Sat, Feb 26, 2022 at 05:30:45AM -0800, Zev Weiss wrote: >> This splits the nct6775 driver into an interface-independent core and >> a separate platform driver that wraps inb/outb port I/O (or asuswmi >> methods) around that core. >> >> Signed-off-by: Zev Weiss <zev@bewilderbeest.net> > >I think it would be much better to convert the entire driver to regmap >and not just use regmap for i2c. This way all register read/write >operations can be hidden behind regmap, and the read/write callbacks >are unnecessary. The tmp401 driver gives an example how to do this - >essentially implement reg_read and reg_write functions in struct >regmap_config, then handle all register accesses through regmap. > >Couple of additional comments inline. >
Alright, that sounds reasonable -- I'll work on an entirely regmap-based v2 (and address the other points as well).
Thanks, Zev
| ![\](/images/icornerr.gif) |