lkml.org 
[lkml]   [2022]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [net-next PATCH] net: dsa: qca8k: pack driver struct and improve cache use
From


On 2/27/2022 15:48, Ansuel Smith wrote:
> Pack qca8k priv and other struct using pahole and set the first priv
> struct entry to mgmt_master and mgmt_eth_data to speedup access.
> While at it also rework pcs struct and move it qca8k_ports_config
> following other configuration set for the cpu ports.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> drivers/net/dsa/qca8k.c | 8 ++++----
> drivers/net/dsa/qca8k.h | 33 ++++++++++++++++-----------------
> 2 files changed, 20 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
> index ee0dbf324268..83b11bb71a19 100644
> --- a/drivers/net/dsa/qca8k.c
> +++ b/drivers/net/dsa/qca8k.c
> @@ -1685,11 +1685,11 @@ qca8k_phylink_mac_select_pcs(struct dsa_switch *ds, int port,
> case PHY_INTERFACE_MODE_1000BASEX:
> switch (port) {
> case 0:
> - pcs = &priv->pcs_port_0.pcs;
> + pcs = &priv->ports_config.qpcs[QCA8K_CPU_PORT0].pcs;
> break;
>
> case 6:
> - pcs = &priv->pcs_port_6.pcs;
> + pcs = &priv->ports_config.qpcs[QCA8K_CPU_PORT6].pcs;
> break;
> }
> break;
> @@ -2889,8 +2889,8 @@ qca8k_setup(struct dsa_switch *ds)
> if (ret)
> return ret;
>
> - qca8k_setup_pcs(priv, &priv->pcs_port_0, 0);
> - qca8k_setup_pcs(priv, &priv->pcs_port_6, 6);
> + qca8k_setup_pcs(priv, &priv->ports_config.qpcs[QCA8K_CPU_PORT0], 0);
> + qca8k_setup_pcs(priv, &priv->ports_config.qpcs[QCA8K_CPU_PORT0], 6);

Should this be QCA8K_CPU_PORT6?
--
Florian

\
 
 \ /
  Last update: 2022-02-28 04:14    [W:0.027 / U:1.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site