lkml.org 
[lkml]   [2022]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v2 2/2] ALSA: core: Remove redundant 'err' variable
Date
Return the result from file->f_op->open() directly instead of
taking this in another redundant variable.

Signed-off-by: Meng Tang <tangmeng@uniontech.com>
---
sound/sound_core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/sound/sound_core.c b/sound/sound_core.c
index aa4a57e488e5..3ac679ea31c7 100644
--- a/sound/sound_core.c
+++ b/sound/sound_core.c
@@ -582,13 +582,12 @@ static int soundcore_open(struct inode *inode, struct file *file)
* We rely upon the fact that we can't be unloaded while the
* subdriver is there.
*/
- int err = 0;
replace_fops(file, new_fops);

if (file->f_op->open)
- err = file->f_op->open(inode,file);
+ return file->f_op->open(inode, file);

- return err;
+ return 0;
}
return -ENODEV;
}
--
2.20.1


\
 
 \ /
  Last update: 2022-02-28 04:07    [W:0.032 / U:0.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site