| Date | Fri, 25 Feb 2022 17:17:27 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCHv3 09/10] nvme: add support for enhanced metadata |
| |
On Tue, Feb 22, 2022 at 08:31:43AM -0800, Keith Busch wrote: > @@ -918,6 +918,30 @@ static blk_status_t nvme_setup_discard(struct nvme_ns *ns, struct request *req, > return BLK_STS_OK; > } > > +static inline void nvme_set_ref_tag(struct nvme_ns *ns, struct nvme_command *cmnd,
Overly long line. But I don't think this should be marked inline anyway.
Otherwise this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
I suspect eventually we'll need to lift the new Identify call into the common revalidation once more fields get added there.
|